ZBLOG

for (OrdersDetail detail : details) { try { if (detail.getState().equals(OrdersDetailState.WAIT_PROCESS)) { //查询订单ID和sku相同的待生产状态订单明细 OrdersDetails detailsWaitProcess = ordersDetai...

要简化这段代码,可以考虑使用函数式编程和流操作来减少重复代码。以下是一个可能的简化版本:

for (OrdersDetail detail : details) {
    try {
        if (detail.getState().equals(OrdersDetailState.WAIT_PROCESS)) {
            distributeNotDeliveredQty(user, detail);
        }

        if (detail.getState().equals(OrdersDetailState.MATCH_IN_PROCESS)) {
            distributeNotDeliveredQtyWithWorksheetCheck(user, detail);
        }
        
        sucess++;
    } catch (Exception e) {
        errors++;
        errorMessage.append(String.format("订单明细取消交付[%s]失败: %s \n", detail.getId(), e.getMessage()));
    }
}

...

private void distributeNotDeliveredQty(User user, OrdersDetail detail) {
    OrdersDetails detailsWaitProcess = ordersDetailRepository.findByOrdersIdSkuAndStates(user.getTenantId(), detail.getOrdersId(), detail.getSku(), detail.getState());
    List<OrdersDetail> sortedList = sortDetailsByDeliveryDate(detailsWaitProcess);

    BigDecimal sumQty = detail.getNotDeliveredQty();
    for (OrdersDetail sortDetail : sortedList) {
        sumQty = sumQty.subtract(sortDetail.getQty());
        if (sumQty.compareTo(ZERO) > 0) {
            this.notDelivered(user, sortDetail, sortDetail.getQty(), sortDetail.getMemo());
        } else {
            this.notDelivered(user, sortDetail, sumQty.add(sortDetail.getQty()), sortDetail.getMemo());
            break;
        }
    }
}

private void distributeNotDeliveredQtyWithWorksheetCheck(User user, OrdersDetail detail) {
    OrdersDetails detailsMatchInProcess = ordersDetailRepository.findByOrdersIdSkuAndStates(user.getTenantId(), detail.getOrdersId(), detail.getSku(), detail.getState());
    List<OrdersDetail> sortedList = sortDetailsByDeliveryDate(detailsMatchInProcess);

    BigDecimal sumQty = detail.getNotDeliveredQty();
    for (OrdersDetail sortDetail : sortedList) {
        if (hasWorksheetOrdersDetail(sortDetail, user)) {
            continue;
        }

        sumQty = sumQty.subtract(sortDetail.getQty());
        if (sumQty.compareTo(ZERO) > 0) {
            this.notDelivered(user, sortDetail, sortDetail.getQty(), sortDetail.getMemo());
        } else {
            this.notDelivered(user, sortDetail, sumQty.add(sortDetail.getQty()), sortDetail.getMemo());
            break;
        }
    }
}

private List<OrdersDetail> sortDetailsByDeliveryDate(OrdersDetails details) {
    return details.stream()
                  .sorted(Comparator.comparing(OrdersDetail::getDeliveryDateEst))
                  .collect(Collectors.toList());
}

private boolean hasWorksheetOrdersDetail(OrdersDetail detail, User user) {
    WorksheetOrdersDetails worksheetOrdersDetails = worksheetOrdersDetailRepository.findByDetailId(detail.getId(), user.getTenantId(), StatusEnum.enable);
    return CollectionUtils.isNotEmpty(worksheetOrdersDetails);
}

这个简化的版本将重复的代码提取到了独立的方法中,并使用流操作来对订单明细进行排序和过滤。这样可以提高代码的可读性和可维护性。请根据实际情况进行适当调整和修改。


内容由零声教学AI助手提供,问题来源于学员提问

本站部分文章来源于网络,版权归原作者所有,如有侵权请联系站长删除。
转载请注明出处:https://sdn.0voice.com/?id=2094

分享:
扫描分享到社交APP
上一篇
下一篇
发表列表
游客 游客
此处应有掌声~
评论列表

还没有评论,快来说点什么吧~

联系我们

在线咨询: 点击这里给我发消息

微信号:3007537140

上班时间: 10:30-22:30

关注我们
x

注册

已经有帐号?